fix: make the tsdb filenames correctly reproducible from the identifier #12536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salvacorts
approved these changes
Apr 9, 2024
| @@ -77,9 +81,13 @@ func (i SingleTenantTSDBIdentifier) Hash(h hash.Hash32) (err error) { | |||
|
|
|||
| // str builds filename with format <file-creation-ts> + `-` + `compactor` + `-` + <oldest-chunk-start-ts> + `-` + <latest-chunk-end-ts> `-` + <index-checksum> | |||
| func (i SingleTenantTSDBIdentifier) str() string { | |||
| ts := i.origTS | |||
| if ts == 0 { | |||
| ts = i.TS.UnixNano() | |||
There was a problem hiding this comment.
nit: I find this a bit hacky. I think a bool flag writeTSAsSecs would read better.
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
This was referenced Apr 17, 2024
This was referenced May 6, 2024
This was referenced May 27, 2024
This was referenced Jun 10, 2024
This was referenced Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In PR #12502, we updated tsdb code to use nanosecond precision in compacted file names.
However, this has caused problems in bloom compactor since the identifier generated while parsing tsdb filenames is not able to regenerate the original filename for old files with unix timestamp since it always uses nanoseconds for generating the filename.
I have fixed the issue by retaining the original timestamp from the file while parsing the names.
Checklist